feat: Remove fluidity from body text and spacing in Compact Mode #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlnr
reviewed
Jul 16, 2024
github-actions
bot
temporarily deployed
to
demo-DES-882-3-fixate-compact-text-level-5
github-actions
bot
temporarily deployed
to
demo-DES-882-3-fixate-compact-text-level-5
dlnr
approved these changes
Jul 17, 2024
github-actions
bot
temporarily deployed
to
demo-DES-882-3-fixate-compact-text-level-5
VincentSmedinga
changed the title
VincentSmedinga
deleted the
feature/DES-882-3-fixate-compact-text-level-5
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, having fluid type in Compact Mode makes less sense now that regular text only grows 2 pixels between window widths of 320 and 1600, which comes down to 0.15%. This PR fixates Text Level 5 to 16 pixels.
This required the sizes to grow a bit slower on narrow screens. I’ve tested it with Amopis, looks good to me.
Because space lengths are based on Text Level 5, this also is no longer fluid in Compact Mode.